googlefonts / geologica

SIL Open Font License 1.1
47 stars 2 forks source link

Reported Fails for the Variable Font #5

Closed vv-monsalve closed 1 year ago

vv-monsalve commented 3 years ago

These are the reported fails on the Varible Font at commit a686c74

All of them are related to some restrictions that currently we have as per the Spec. The first one regarding the allowed fvar instances; the other two, are related to the slnt/ital axes that were disabled due to browser support.

Currently, the Italics are handled not as an axis but split into different files (roman+italics). By doing that, the instances for slant and sharp axis could be included in the Stat table but avoided in the fvar table.

Cabin could work as a reference since is a project with italics and a "Condensed" variant only referenced in the VF trough the Stat Table

@davelab6 would you confirm this approach? or would you have another example?

🔥 FAIL: Check variable font instances have correct names * [com.google.fonts/check/varfont_instance_names](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/varfont_instance_names) * 🔥 **FAIL** Following instances are not supported: - Sharp Thin - Sharp Thin Italic - Sharp ExtraLight - Sharp ExtraLight Italic - Sharp Light - Sharp Light Italic - Sharp Regular - Sharp Italic - Sharp Medium - Sharp Medium Italic - Sharp SemiBold - Sharp SemiBold Italic - Sharp Bold - Sharp Bold Italic - Sharp ExtraBold - Sharp ExtraBold Italic - Sharp Black - Sharp Black Italic Further info can be found in our spec https://github.com/googlefonts/gf-docs/tree/master/Spec#fvar-instances [code: bad-instance-names]
🔥 FAIL: Ensure VFs do not contain slnt or ital axes. * [com.google.fonts/check/varfont/unsupported_axes](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/varfont/unsupported_axes)
--- Rationale ---

The 'ital' axis is not supported yet in Google Chrome. The 'opsz' axis also has
patchy support.

For the time being, we need to ensure that VFs do not contain either of these
axes. Once browser support is better, we can deprecate this check.

For more info regarding ital and opsz browser support, see:
https://arrowtype.github.io/vf-slnt-test/

* 🔥 **FAIL** The "ital" axis is not yet well supported on Google Chrome. [code: unsupported-ital]
🔥 FAIL: Check correctness of STAT table strings * [com.google.fonts/check/STAT_strings](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/STAT_strings)
--- Rationale ---

On the STAT table, the "Italic" keyword must not be used on AxisValues for
variation axes other than 'ital'.

* 🔥 **FAIL** The following AxisValue entries on the STAT table should not contain "Italic": ['nameID 257: Italic'] [code: bad-italic]
kosbarts commented 3 years ago

We have been waiting to hear if there are any updates on this from @davelab6 on the spec.

Btw, I think the text for the FAIL report re ital axis should be updated. Description says "... do not contain slnt or ital axes" but Rationale talks about "ital" and "opsz".

vv-monsalve commented 3 years ago

Hi @kosbarts I was waiting to have some news on this but, as it is something that should be considered with GF API engineers it takes more time and process as there are many aspects to take into consideration.

Currently, due to the limited browser support for 'ital' axis to publish the complete Family including italics, the source file must be split into Roman and Italics, e.g. Cabin or Karla. Otherwise, if you prefer to keep the single source file, the project would be published serving only the Roman variant, just like in Comissioner.

vv-monsalve commented 3 years ago

After pulling the latest files at commit 029a54c and perform new FB under the latest 0.7.33 version, an additional Fail was reported:

🔥 FAIL: Check glyphs do not have components which are themselves components. * [com.google.fonts/check/glyf_nested_components](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/glyf.html#com.google.fonts/check/glyf_nested_components)
--- Rationale ---
ve been bugs rendering variable fonts with nested components. Additionally,
some static fonts with nested components have been reported to have rendering
and printing issues. (See googlefonts/fontbakery#2961 and
arrowtype/recursive#412.)

* 🔥 **FAIL** The following glyphs have components which themselves are component glyphs: * uni01C4 * uni01C5 * uni01C8 * uni01CB * uni1EDA * uni1EE2 * uni1EDC * uni1EDE * uni1EE0 * uni1EE8 and 104 more. [code: found-nested-components]

This Fail is related to our OutlinesQuality Checklist. Please inspect it and ensure it is covered for Geologica.