search

googlefonts / gf-glyphs-scripts

Scripts for Glyphs
21 stars 11 forks source link

Copyright string check / OFL copyright mismatch error #29

Open noponies opened 6 years ago

noponies commented 6 years ago

I get the following error when running QA from Glyphs (Version 2.5.1 (1141)) "OFL.txt and font copyright do not match." when as far as I can tell, they are functionally the same. Have checked for hidden characters etc; and not found anything amiss. Copyright is on first line of OFL.txt.

Strings in question below;

OFL copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road) Font copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road)

m4rc1e commented 6 years ago

Thanks @noponies. I'll look into this!

m4rc1e commented 6 years ago

@noponies your OFL.txt line endings are for Windows, http://www.cs.toronto.edu/~krueger/csc209h/tut/line-endings.html. I see we use Unix line endings for the OFLs in https://github.com/google/fonts/tree/master/ofl

I'm keeping this open for the time being.

noponies commented 6 years ago

Thanks for the reply.

I opened up the OFL.txt file and converted to Unix/MacOS line endings, re ran the QA test suite and it passed.

I originally sourced the OFT.txt file from SIL and re checking a fresh download of that shows it has Windows line endings.