search

googlefonts / gf-glyphs-scripts

Scripts for Glyphs
21 stars 11 forks source link

QA: Update checks to pass ArchivoBlack #34

Closed m4rc1e closed 6 years ago

m4rc1e commented 6 years ago

Whilst QAing Archivo Black, https://github.com/Omnibus-Type/ArchivoBlack, I came across the following two false positives.

================================================================================
FAIL: Check single weight families have Regular style name
--------------------------------------------------------------------------------
'Italic' instance name is incorrect.

Families which have just one instance must name the single 'Regular'

================================================================================
FAIL: Check Win Ascent and Win Descent equal yMax, yMin of bbox
--------------------------------------------------------------------------------
Regular master's winDescent 303 is not equal to yMin 271

Check single weight families have Regular style name Implementation of this check was wrong. Updated implementation will collect all the instances then check there's only 1 instance. That instance should be Regular.

Check Win Ascent and Win Descent equal yMax, yMin of bbox Implementation now matches Fontbakery's, https://github.com/googlefonts/fontbakery/issues/1655. Previously, the win Ascent and Descent had to match the family's yMin and yMax.