googlefonts / gf-glyphs-scripts

Scripts for Glyphs
21 stars 11 forks source link

Copyright notice check has incorrect assumption about date #62

Open davelab6 opened 4 years ago

davelab6 commented 4 years ago

https://github.com/googlefonts/gf-glyphs-scripts/blob/f93799f2ee67c30b442ded873a76b71341057a23/Google%20Fonts/qa.py#L192-L208

This check is wrong, the copyright date should be the earliest date that the project started, not the current date. There is likely no way to check that date programmatically, so a regex that checks for 4 digits making the year is sufficient (likely started 19 or 20 :)

m4rc1e commented 4 years ago

Good catch.

I'll be revisiting this repo in the next few weeks so it follows our new spec. I want the fix script to be able to output a flawless VF.