search

googlefonts / gftools

Misc tools for working with the Google Fonts library
Apache License 2.0
242 stars 71 forks source link

`gftools builder --generate` fails on some config files containing `includeSubsets` key #1003

Closed cmyr closed 1 month ago

cmyr commented 1 month ago

And this key is present in at least some configs, e.g.

https://github.com/notofonts/imperial-aramaic/blob/main/sources/config-sans-imperial-aramaic.yaml and https://github.com/notofonts/takri/blob/main/sources/config-sans-takri.yaml.

simoncozens commented 1 month ago

Noto fonts are doing something a bit clever. To allow seamless migration from their old idiosyncratic build system (which used this kind of config file) to builder2, they use a variant of gftools-builder called notobuilder; where gftools-builder has an implicit recipeProvider: googlefonts, notobuilder has an implicit recipeProvider: noto. So they are not expected to build under gftools-builder, but adding the explicit recipe provider is probably a good idea. At any rate, if anything a Noto bug not a gftools one.