googlefonts / gftools

Misc tools for working with the Google Fonts library
Apache License 2.0
243 stars 70 forks source link

font-tags: turn into local webapp #1013

Closed m4rc1e closed 2 months ago

m4rc1e commented 3 months ago

The spreadsheets have become a nightmare to maintain so I've created a webapp that users run locally to edit font tags instead. The app works directly on the tagging csv so we can drop the spreadsheets.

To use the app run gftools font-tags path/to/google/fonts

rsheeter commented 3 months ago

I don't think we want users to run python, just give them a url. github pages (ala https://rsheeter.github.io/android_fonts/emoji.html?q=) or even codepen (poc https://codepen.io/rs42/pen/mdZwdZM) seems likely to be sufficient unless there is some capability that requires python?

davelab6 commented 3 months ago

unless there is some capability that requires python?

Well, the workflow Marc actually has is editing the file locally, so, in the httpd() call he has,

           "Once you're done editing, remember to commit the changes in "
           "your google/fonts repo and open a pr."

But all the py code is doing is loading the CSV and serving it via a httpd; this is useful for a local workflow since then the file is edited and can be directly committed.

For a github pages version, I think "all" Marc has to do is use the Github API (using something like https://github.com/elwayman02/ember-data-github) to load and commit the tags csv file directly. (Your plain js codepen example is good for loading the file, but presents a workflow challenge.)

Both workflows are worth supporting, imo

rsheeter commented 3 months ago

I would just let the user download either an updated file or a diff to use for a PR. That simplifies things and is a major improvement over the spreadsheet workflow. Most of the benefit at very low cost, near-0 maintenance because there are no dependencies or scary operations.

m4rc1e commented 3 months ago

SGTM. I'll drop the server and just host it on the google/fonts gh-pages.

davelab6 commented 3 months ago

MVP :)

rsheeter commented 3 months ago

MVP :)

+1. Launch, begin to capture value, and iterate.

m4rc1e commented 2 months ago

Closing since this has moved to google/fonts, https://google.github.io/fonts/tags.html