googlefonts / gftools

Misc tools for working with the Google Fonts library
Apache License 2.0
242 stars 71 forks source link

Are we exporting OTF-CFF from sources converted to TTF? #770

Open RosaWagner opened 10 months ago

RosaWagner commented 10 months ago

For the Intel Mono project we noticed gftools builder was turning the sources to TTF masters before exporting OTF-CFF binaries, instead of exporting directly from the sources that have postscript contours —ending up in otf-cff files with gasp and prep tables. This seems to be a Builder issue since exporting directly with Fontmake is okay.

Also reported by designers but that may be a Fontmake issue (not builder):

ref: https://github.com/RosaWagner/intel-one-mono/tree/googlefonts

simoncozens commented 10 months ago

we noticed gftools builder was turning the sources to TTF masters before exporting OTF-CFF binaries

I don't understand this. What do you mean by "TTF masters"?

ending up in otf-cff files with gasp and prep tables

If this is the symptom, the problem is likely that we are using gftools-fix on the output binaries, which adds a gasp and prep if there is not one already.

RosaWagner commented 10 months ago

When I export OTF-CFF font only, a directory is created which is "instances_ttf", which doesn't seem logical. It might be unrelated, but it made me think that the otf-cff gets exported from them? I don't know, hence the question mark in title.

If this is the symptom, the problem is likely that we are using gftools-fix on the output binaries, which adds a gasp and prep if there is not one already.

Ok makes sense.

simoncozens commented 10 months ago

a directory is created which is "instances_ttf", which doesn't seem logical.

It should be instance_ufo, I just typoed.