search

googlefonts / gftools

Misc tools for working with the Google Fonts library
Apache License 2.0
242 stars 71 forks source link

Add subsets check to PR checklist #978

Closed yanone closed 2 months ago

simoncozens commented 2 months ago

I understand the intention, but if this is not happening then there's a bug in add-font in gftools.

yanone commented 2 months ago

Found just now that Fustat was also missing the Arabic subset. While that's surely a bug, I implore you to add this check to the list, because it hurts no one to spend that one second of attention to the subsets.

I missed the malfunction of the subset detection algo for a full three fonts and I feel really aweful about it.

m4rc1e commented 2 months ago

I'm merging this but we should work on a better way to determine what subsets are needed such as #982