googlefonts / glyphsLib

A bridge from Glyphs source files (.glyphs) to UFOs
Apache License 2.0
182 stars 52 forks source link

glyphsLib does not handle localized names in Glyphs #633

Open aaronbell opened 4 years ago

aaronbell commented 4 years ago

I'm working on a font that has a localized name in Glyphs. While I see the key showing up in the UFO's lib file, it isn't being processed and put into the UFO fontinfo NameRecords. As such, the font that is generated out of fonttools lacks the proper localized name.

Here is the relevant key from the lib file: com.schriftgestaltung.customParameter.GSFont.localizedFamilyName Japanese;しっぽりアンチック

Here is a sample Glyphs file that has a localized name: ShipporiAntiqueMKanaLantenOnly.glyphs.zip

m4rc1e commented 4 years ago

It seems GlyphsApp has two customParameters which allow users to create name records which are not (3, 1, 0x409) or (1, 0, 0); "Name Table Entry" and "localized*Name". Ideally, we should support both but perhaps a good starting point is to support "Name Table Entry" since it's more flexible?

Unfortunately both customParams are not so straight forward to implement. "Name Table Entry" is a string that we'll need to parse and for "localized*Name", we'll need to create a constant which maps the language names to langIDs, platformIDs etc. There's probably a lot of magic happening as well, for instance if you add a localizedFamilyName, it will create a localizedSubFamilyName even if it hasn't been specified.

aaronbell commented 4 years ago

Thanks Marc! It sounds like I'll need to manually add those fields for now.