search

googlefonts / glyphsLib

A bridge from Glyphs source files (.glyphs) to UFOs
Apache License 2.0
178 stars 51 forks source link

markFeatureWriter: Skip ignorable anchors #964

Closed khaledhosny closed 7 months ago

khaledhosny commented 7 months ago

Glyphs allows anchors to start with non-letter characters and these are used internally to align components and should not be exported to the feature file.

Fixes https://github.com/googlefonts/glyphsLib/issues/963

anthrotype commented 7 months ago

@khaledhosny thanks. Could you by any chance try to see if this glyphsLib-specific markFeatureWriter will continue to work with the changes in https://github.com/googlefonts/ufo2ft/pull/796 ?

simoncozens commented 7 months ago

* is not ignorable, though.

khaledhosny commented 7 months ago

* is not ignorable, though.

It is already handled and dropped from the name before the new check is called.

khaledhosny commented 7 months ago

@khaledhosny thanks. Could you by any chance try to see if this glyphsLib-specific markFeatureWriter will continue to work with the changes in googlefonts/ufo2ft#796 ?

Seems to work (as in no tests are failing, expect a minor change to test_contextual_anchors since more lookups are created).