this if branch was never true because of a typo (the author probably meant to compare axis.minimum with 'axis_min' instead of 'axis_max'); but besides that, even if we did fix the typo, it would be incorrect to ignore such an explict always-true axis rule where both min and max are explicitly declared and are equal to the axis min/max. Glyphs.app exports a GSUB with a FeatureVariation table with an empty condition set (which means always apply), and fontmake does the same.
The PR doesn't change anything, only removes code that's never evaluated so no functional change.
this
ifbranch was never true because of a typo (the author probably meant to compare axis.minimum with 'axis_min' instead of 'axis_max'); but besides that, even if we did fix the typo, it would be incorrect to ignore such an explict always-true axis rule where both min and max are explicitly declared and are equal to the axis min/max. Glyphs.app exports a GSUB with a FeatureVariation table with an empty condition set (which means always apply), and fontmake does the same.The PR doesn't change anything, only removes code that's never evaluated so no functional change.