Open simoncozens opened 6 months ago
That was changed after this discussion: https://github.com/googlefonts/glyphsLib/issues/745#issuecomment-1380367686
I’ll look into the "1".
Just hit some weird issues in fontmake with the compatibility checker dying:
% fontmake -o variable -g sources/AndadaPro.glyphs
if not CompatibilityChecker(source_fonts).check():
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/simon/others-repos/fontmake/Lib/fontmake/compatibility.py", line 26, in check
first = self.fonts[0]
~~~~~~~~~~^^^
IndexError: list index out of range
This turns out to be the same issue! Because the axis mappings are upside down, we produce designspace files like so:
<axes>
<axis tag="wght" name="Weight" minimum="96" maximum="140" default="96">
<map input="96" output="400" />
<map input="140" output="840" />
</axis>
</axes>
<sources>
<source filename="AndadaPro-Regular.ufo">
<location>
<dimension name="Weight" xvalue="96" />
</location>
</source>
<source filename="AndadaPro-XBold.ufo">
<location>
<dimension name="Weight" xvalue="140" />
</location>
</source>
</sources>
and when splitInterpolable
runs on this, it produces a designspace with no sources, which gets handed to the compatibility checker, and self.fonts
is empty.
Let's take Nunito.glyphs which is a Glyphs 2 file and convert it to designspace. The weight axis mappings look like this:
In Glyphs, I open the file, change it to file format 3 and save it. When run through glyphs2ufo, the axis mapping now looks like this:
I think this is because Glyphs changed its understanding of the Axis Mapping custom parameter, so that's a pain but it probably can't be helped.
Let's get rid of the Axis Mapping custom parameter, save the Glyphs file, and try again, relying on the axis coordinates in the instances to provide the mapping.
Where did that "1" come from?