search

googlefonts / glyphsLib

A bridge from Glyphs source files (.glyphs) to UFOs
Apache License 2.0
178 stars 51 forks source link

Support fonts named Oblique instead of Italic #999

Open robmck-ms opened 2 months ago

robmck-ms commented 2 months ago

We have a font that is an Oblique, not a true Italic, so we named it Oblique. When creating UFOs, or building static TTFs, the style name for the Obliques would be "Oblique Italic" and "Bold Oblique Italic". I added "Oblique" as an alternative where names were previously tested only for "Italic".

While investigating this, I noticed that the styleMapStyleName was not getting set correctly in the case of Bold Italic (it was getting set as Italic, not Bold and Italic), thus the macStyle and fsSelection bits were not getting set correctly (both the Italic and Bold Italic had bits set the same: i.e. Italic and not Bold). So I changed is_bold=(stylename=="Bold") to is_bold=("Bold" in styleName) in to_ufo_names.

I also added test cases for both.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

robmck-ms commented 1 month ago

Sorry for the delay. This PR should be ready to go now. Please let me know if there are any issues.