search

googlefonts / googlefonts.github.io

Google Fonts documentation
https://googlefonts.github.io
Apache License 2.0
58 stars 27 forks source link

Clarify source file requirements #109

Closed eliheuer closed 1 year ago

eliheuer commented 1 year ago

It is not clear in multiple sections of the GF-Guide that .ufo, .glyphspackage, and .glyphs are the only formats that currently fully work in the Google Fonts system.

I also added reference to the .glyphspackage format in all sections of the docs where source files are discussed and encouraged its use. The reasoning being that .glyphspackage is easier to use with version control and also makes merging PRs to the source files easer because you don't have to overwrite the full file, which requires a lot of trust and can introduce unintended changes.

vv-monsalve commented 1 year ago

@RosaWagner did you read my comments?

RosaWagner commented 1 year ago

@vv-monsalve where?

vv-monsalve commented 1 year ago

I made some comments in the files. The preview appears right above here (at least on my end). But the comments are there in the reviewed file.

Screen Shot 2023-09-12 at 9 18 52
RosaWagner commented 1 year ago

@vv-monsalve I don't see them, probably because of the pending status, did you click the button that publishes the review? @eliheuer can you amend the PR taking vivi's comment into acocunt?

vv-monsalve commented 1 year ago

did you click the button that publishes the review?

Probably forgot to hit it :(