search

googlefonts / googlefonts.github.io

Google Fonts documentation
https://googlefonts.github.io
Apache License 2.0
58 stars 27 forks source link

Fix typos #133

Open n8willis opened 8 months ago

n8willis commented 8 months ago

This is the results of running aspell and a tiny bit of manual adjustment; it only attempts to fix easy-to-verify typos, not anything related to phrasing/readability/consistency etc.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

n8willis commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

From my POV, I don't regard any of the fixes in this PR to be a contribution of any real insight or significant originality that would rise to the level of Original Work. Doubly so since it was done with an automating spell-checking utility.

davelab6 commented 6 months ago

I agree but then I would expect you to have signed the CLA already ;) please sign

n8willis commented 6 months ago

The wrinkle is that the bot only looks at the user.email parameter on the commits, which by default is the generic @ users.github.com noreply/alias/mask. So back when I did sign a CLA for a Google project, I did it with a real email address. I can't/shouldn't sign it a second time with the alias/mask one because that links to multiple email IDs that I need to keep separate from each other.

So I either would have to redo the PR from a different set of commits with a bot-aware address on them or go back and try to git amend that on all the commits. Not sure if GitHub's PR mechanism would handle that, but it might. Either way, this was just something I did on my own un-contracted time, so I can get back to it someday, but I don't know exactly when I'll have the spare cycles.

vv-monsalve commented 5 months ago

@n8willis, could you please check and resolve the conflicts in the python.md it was unclear which version should be kept.

vv-monsalve commented 3 weeks ago

@n8willis, could you please check and resolve the conflicts in the python.md it was unclear which version should be kept.

@n8willis, this is a friendly nudge. The compromised python.md file significantly changed in a way that cannot be easily assessed, and the reported conflicts cannot be solved. Could you please review and resolve it?