search

googlefonts / literata

A contemporary serif typeface family for long-form reading
SIL Open Font License 1.1
237 stars 20 forks source link

Added missing styleMapFamilyName and styleMapStyleName attributes for style grouping (followup PR) #27

Closed felipesanches closed 2 years ago

felipesanches commented 3 years ago

Originally posted by @kokoshneta on on Jun 12, 2020 as PR #22 but closed during our migration of default branch name from "master" to "main" in this repo.

Be sure to also see original comments made at PR #22

Original PR description:

The instances in the existing .designspace files were missing styleMapFamilyName and styleMapStyleName attributes, causing each generated fonts to be the Regular style of its own style group.

Additionally, the medium weights were incorrectly labelled, with names and style names out of sync; they also lack a node.

These files have been manually edited to include the correct attributes, and the medium weights have been moved to their logical locations and provided with matching names and style names. The missing nodes have not been added.

Be sure to also see original comments made at PR #22

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

kokoshneta commented 3 years ago

@googlebot I consent.

kokoshneta commented 3 years ago

(Not sure if my consent was counted or lost with the migration stuff here, so the previous comment was just in case.)

kokoshneta commented 3 years ago

I can’t quite figure out if I need to do anything to resolve the conflicts that are preventing this from being mergeable. Should I rebase my fork from the new main branch?

davelab6 commented 3 years ago

I guess next time the fonts are officially updated this will be taken care of