search

googlefonts / nanoemoji

A wee tool to build color fonts.
Apache License 2.0
239 stars 19 forks source link

take first in multi-palette CPAL; convert 0xFFFF palette index to SVG fill="currentColor" #423

Closed anthrotype closed 2 years ago

anthrotype commented 2 years ago

in an attempt to fix https://github.com/googlefonts/nanoemoji/issues/421 and allow ReekKufiInk be converted from COLRv1 to OT-SVG...

rsheeter commented 2 years ago

I do wonder if the 0 width check shouldn't still exist somewhere for bitmaps only. Still seems like a good change. Can we add something like a very narrow subset of the arabic mark example to expose these issues in a test?

anthrotype commented 2 years ago

i'll disentangle the issue about multiple CPAL palettes (this PR) from the one about zero-width glyphs, for which I am filing a separate PR https://github.com/googlefonts/nanoemoji/pull/424

anthrotype commented 2 years ago

I rebased this on top of #424, so the latter should be merged first. This PR basically adds the last commit 6e8e43c

anthrotype commented 2 years ago

@rsheeter I also took the liberty to fix #405 with https://github.com/googlefonts/nanoemoji/pull/423/commits/3807fc336c33d6f3e9c561d2362dc4763f9d8c69 since I was touching those lines anyway and was a small fix

rsheeter commented 2 years ago

Nice. Once this is merged/released you should maximum_color reem kufi ink on google/fonts :)

anthrotype commented 2 years ago

Once this is merged/released...

https://github.com/googlefonts/nanoemoji/releases/tag/v0.14.0

anthrotype commented 2 years ago

...you should maximum_color reem kufi ink on google/fonts :)

FYI I'm travelling tomorrow so I won't be able to do that until next week (in cause you want to give that a try)