search

googlefonts / nanoemoji

A wee tool to build color fonts.
Apache License 2.0
239 stars 19 forks source link

maximum_color: skip svg table generation for colr v0 fonts #434

Closed m4rc1e closed 1 year ago

m4rc1e commented 1 year ago

For fonts released on Google Fonts, we don't want to run maximum_color on colr v0 fonts since they're well supported in modern browsers.

Feel free to close this if you feel it's too restrictive. I can always move this functionality to our own gftools builder so it will only work on fonts destined for GF.

m4rc1e commented 1 year ago

No doubt the tests are probably going to explode here.

anthrotype commented 1 year ago

I don't think I want to do that. The tool supports this, there may be other valid reasons for one wanting to make an OT-SVG table from a COLRv0 font nonetheless (e.g. some app out there may support only the former). It's up to the user to decide whether to do it or not.

m4rc1e commented 1 year ago

Ok cool. I'll move this into our own builder.

rsheeter commented 1 year ago

+1 to doing this in GF specific code.