googlefonts / nanoemoji

A wee tool to build color fonts.
Apache License 2.0
239 stars 19 forks source link

Switch from deprecated "toml" library #452

Closed CyberTailor closed 1 year ago

CyberTailor commented 1 year ago

Fixes #451

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

rsheeter commented 1 year ago

Ty for the PR. Apologies for the inconvenience but would you be willing to sign the CLA? - we can't accept otherwise.

CyberTailor commented 1 year ago

I've signed it

CyberTailor commented 1 year ago

https://github.com/googlefonts/nanoemoji/pull/452/checks?check_run_id=13637748132

anthrotype commented 1 year ago

thanks. Can you please run black auto-formatter so that the lint CI job passes as well?

https://github.com/googlefonts/nanoemoji/actions/runs/5036873831/jobs/9036557954?pr=452

anthrotype commented 1 year ago

@CyberTailor oh, I see the lint job failing has nothing to do with your specific PR, it's just a new black version that changed the way it wants to format things (and we keep deps un-pinned so this can happen /cc @rsheeter). You can ignore this, we can fix up later on after merge.

anthrotype commented 1 year ago

python 3.7 complains importlib.resources has no attribute "files"

https://github.com/googlefonts/nanoemoji/actions/runs/5044764986/jobs/9048275533?pr=452#step:5:71

do you mind not reverting that line change for now use the old deprecated method, we may want to drop 3.7 support at some point but maybe not immediately in this PR.

anthrotype commented 1 year ago

I see that files method is 3.9+ only, we do want to support 3.8 for a bit longer. I would rather we keep the deprecation warning (or if we really don't want to see that, only use the newer API for 3.9+)

CyberTailor commented 1 year ago

do you mind not reverting that line change for now use the old deprecated method, we may want to drop 3.7 support at some point but maybe not immediately in this PR.

Reverted.

anthrotype commented 1 year ago

thank you for the contribution and for the patience :)