Open SaveTheRbtz opened 2 years ago
The new flags for BL, BQ, MQ, and RE, though the official flags, are duplicates of other flags and do not match the flags used by most other fonts. It wouldn’t be incorrect to change the flags, but it might be undesirable.
CQ and UK are not valid region codes in CLDR, so they should not be used for emoji flags.
For the changed flags seems like these aliases all have a dedicated subregions e.g.: FR-BL, NL-BQ, FR-MQ, FR-RE. Maybe if custom flag is desired it should be referenced as a subregion while region should use NL/FR flags? (I can add add FR and NL subdivisions to the upstream repo.)
As for UK and CQ, it should be fine since they are not yet a part of SELECTED_FLAGS
: https://github.com/googlefonts/noto-emoji/blob/2203a2217694d8447ed4a4c2d3752cdb125f5852/Makefile#L56-L82
(Although, I would suppose, given that CQ has a 2 letter ISO code, it's just a matter of time before it is added to CLDR.)
PS. As for some flags being the same-- this is a side effect of one of the downstream build systems (IIRC npm) that had trouble with symlinks. Since they are byte-by-byte identical this should not have long-term negative effect on the git history size. As for the potential font size increase we can add these to either https://github.com/googlefonts/noto-emoji/blob/2203a2217694d8447ed4a4c2d3752cdb125f5852/emoji_aliases.txt#L7 or https://github.com/googlefonts/noto-emoji/blob/2203a2217694d8447ed4a4c2d3752cdb125f5852/materialize_emoji_images.py#L39
A friendly ping ^ =)
Note that Sark (CQ) has been added to CLDR regions https://github.com/unicode-org/cldr/blob/main/common/validity/region.xml / https://github.com/unicode-org/icu/pull/2338/files
This updates upstream to 1.2.1 release. It contains quite a bit of changes: