search

googlefonts / noto-emoji

Noto Emoji fonts
SIL Open Font License 1.1
3.74k stars 451 forks source link

colrv1_postproc.py: set OS/2.fsType=0 to remove font embedding restrictions #418

Closed anthrotype closed 1 year ago

anthrotype commented 1 year ago

The old CBDT/CBLC font similarly has no font embedding restrictions (OS/2.fsType=0), so the COLRv1 font needs to match that.

Currently we weren't changing that and the font ended up using ufo2ft's default value for OS/2.fsType which is 4 (i.e. preview and print only).

Fixes https://github.com/google/fonts/issues/5729

anthrotype commented 1 year ago

I haven't actually run the postproc script.. the fonts are unchanged. should I?

anthrotype commented 1 year ago

in fact.. it crashes lol

but for unrelated reasons from this change:

$ python colrv1_postproc.py
Updating fonts/Noto-COLRv1.ttf from fonts/NotoColorEmoji.ttf
cannot process alias fe82b -> unknown_flag
Traceback (most recent call last):
  File "/usr/local/google/home/clupo/oss/noto-emoji/colrv1_postproc.py", line 332, in <module>
    app.run(main)
  File "/usr/local/google/home/clupo/.pyenv/versions/fonttools-py310/lib/python3.10/site-packages/absl/app.py", line 308, in run
    _run_main(main, args)
  File "/usr/local/google/home/clupo/.pyenv/versions/fonttools-py310/lib/python3.10/site-packages/absl/app.py", line 254, in _run_main
    sys.exit(main(argv))
  File "/usr/local/google/home/clupo/oss/noto-emoji/colrv1_postproc.py", line 323, in main
    _add_fallback_subs_for_unknown_flags(colr_font)
  File "/usr/local/google/home/clupo/oss/noto-emoji/colrv1_postproc.py", line 192, in _add_fallback_subs_for_unknown_flags
    unknown_flag = cmap[UNKNOWN_FLAG_PUA]
KeyError: 1042475

@rsheeter do you happen to know what's going on?