search

googlefonts / opensans

Open Sans font
Other
212 stars 31 forks source link

Missing SemiBold and SemiBoldItalic #2

Closed m4rc1e closed 6 years ago

m4rc1e commented 6 years ago

All styles which are currently being served must exist

screen shot 2018-02-07 at 08 54 15

laerm0 commented 6 years ago

Ah, so the issue is that the names of Semi and Extra just need to be changed to have the hyphens, right?

m4rc1e commented 6 years ago

Nope,

you're missing the weights. The fonts dir in this repo does not contain Semi weights.

As a side note, GF displays SemiBold as Semi-Bold on the site. This happens on the front end only, files are not touched.

laerm0 commented 6 years ago

Oh, that's old data. My new stuff here hasn't been PR'd in yet. Check those files please.

m4rc1e commented 6 years ago

Compile and ship them please. The ttf still doesn't have those weights.

laerm0 commented 6 years ago

I'm confused... Open Sans wasn't manually hinted. Also, the hinted_ttfs folder clearly has semibold. The ttfs directory was from last year and all that was was my merging Hebrew into the Latin.

m4rc1e commented 6 years ago

Thanks, much clearer.

What's the point of the ttfs dir. Sounds like these fonts are out of date?

If we can, I'd prefer to have just one set of fonts

laerm0 commented 6 years ago

Yeah, I guess those were a previous step in the process. It didn't occur to me that you'd be looking at the ttfs and not the Glyphs source. I suppose all GF technically cares about is how the ttfs look, right?

davelab6 commented 6 years ago

How was it hinted?

laerm0 commented 6 years ago

ttfautohint --composites --strong-stem-width GD right out of Glyphs.

davelab6 commented 6 years ago

Yeah, I guess those were a previous step in the process. It didn't occur to me that you'd be looking at the ttfs and not the Glyphs source. I suppose all GF technically cares about is how the ttfs look, right?

We have some checks for .glyphs files, but they are not as thorough as the .ttf checks; and the latter is required because (as you've just seen from surveying the "add fonts" queue :) we have a pretty wide variety of source files and build processes that will never become the same.

davelab6 commented 6 years ago

Open Sans wasn't manually hinted

Hmm, not sure what you mean - the version currently in Google Fonts API was manually hinted.

Closing this issue; https://github.com/googlefonts/opensans/tree/master/hinted_ttfs has the SemiBold files, and other stuff that came up is tracked in other issues.