L1 Mastering Font checklist

vv-monsalve commented 3 years ago

Diacritics

[x] Inspect the font and choose the best version of the diacritics (in terms of balance, weight, size, contrast) and move them to comb mark.
[x] Adjust left and right sidebearings of all the comb marks to 0.
[x] Work on the selected diacritics to ensure the balance among all marks (contrast, weight, size, stroke or others)
[x] Adjust position, weight, or outlines of the diacritics if needed to, without changing the design of them by using glyphs app locked guidelines.
[x] Test the comb marks by inspecting all of them in context (right click and choose all glyphs using this component).
[x] Inspect and balance the below marks (size, weight, balance) e.g. ogonek cedilla to avoid huge marks
[x] Delete the legacy marks and add them back so they are made from comb marks.
[x] Create comb.case marks by making them less tall and less narrow while keeping them at the same weight. (Preferable at the height they are intended to use, to be able to inspect them at their context)
[x] Create the Vietnamese mark.
[x] Make component glyphs for all of the font.
[x] Adjust the anchor position.
[x] Run the automatic glyphsapp command: update gyph info

Glyphs & Outlines

[x] Create the missing glyphs needed
[x] Run the automatic glyphsapp command: Add extremes, Correct outlines direction, Remove PS Hint.
[x] Check kerning and spacing by using the txt files. Fix any kerning and spacing errors if needed for the most common kerning pairs.
[x] Run the automatic glyphsapp command: Resolve all metrics to update the metrics in all the font.
[x] Check everything once again by going glyph by glyph.
[x] Run the automatic glyphsapp Update Glyph Info command to avoid bad names issues
[x] Run the automatic glyphsapp Convert to cubic command to avoid qcurves

OT Features

[x] Check OpenType features and see if all listed are valid, e.g. if .fina glyphs are actually ending shapes or ss are not repeated under different names.
[x] Inspect if Stylistic Sets have the right name or rename .001 etc... glyphs and generate the automatic OpenType code.
[x] Check if there is a stylistic set that would correspond to SmallCaps feature instead and change it.
[x] Check if the OpenType code has any error.
[x] Hit the update & compile buttons to check everything is working well.

Testing changes

[x] Inspect the font created by the CI GHA to check production errors. If the action isn't included yet in the repo, export and test the font using Glyphs.
[x] Check the before and after font using gen-html diff if needed (for update font cases)
[x] Check the font on gen-html proof to see if it's working well on web. Use the --imgs flag to produce images.
[x] Commit and make PR using images.

vv-monsalve commented 3 years ago

Hi @crystaltype, there are some issues around Passions Conflict diacritics (please take the latest font in the repo to solve them):

Inconsistencies among related marks (weight, size, terminals)
Marks using scaled components, therefore leading to not rounded coordinates
Duplicated nodes (missing to run the tidy up paths command)
Overall balance in weight among diacritics + alignment. E.g. Tilde is bigger than the average; Macron alignment

crystaltype commented 3 years ago

Thanks @vv-monsalve I've made a PR with these problems solved.

googlefonts / passions-conflict