googlefonts / praise-script

Praise Script fonts
SIL Open Font License 1.1
2 stars 3 forks source link

Advance Mastering #7

Open vv-monsalve opened 2 years ago

vv-monsalve commented 2 years ago

L2 – High Quality Outlines

L3 – Spacing & Kerning

L4 – OT features revision & improvement

L5 – Additional improvements & VF planning

lilasymons commented 2 years ago

See Sheet with suggested revised level addition, so we can discuss further, and I can give estimate for project completion and give update on time left, and other project estimates.

So far: A-z lc and Caps have clean outlines and spacing and work well amongst each other with no kerning!

Questions Is there a reason why the default lc k looks like kgreenlandic? Proposed adding a ascender and connect to be harmonious with the rest of the a-z lc character set:

k_suggestion

Next steps:

vv-monsalve commented 2 years ago

Hi @lilasymons

Is there a reason why the default lc k looks like kgreenlandic? Proposed adding a ascender and connect to be harmonious with the rest of the a-z lc character set:

It was outside the scope of L1 development. It is part of the improvements expected within the L2 - L5 development.

On the k above, please review the connection that seems heavier than the others. Also, please leave the current k available in the file (possibly as part of another ss so that any user currently using it could have access to it)

In this regard, I wonder how much could the shapes change @davelab6 (to avoid regressions/complaints)?

double check clean outlines for accents and make sure anchor points are matching orig file so components are correct (saw a lot of errors/misplaced anchor points from the orig file shared.

Please remember to always open an issue on these topics with details (+ images), so we can quickly review/discuss/decide there. Ideally, one per each theme, e.g. "anchors" another for "shapes or drawing inconsistencies" and so on.

vv-monsalve commented 2 years ago

Also, remember to:

lilasymons commented 2 years ago

For dcaron.ss03/lcaron.ss03/tcaron.ss03 should those glyphs be substituted for something less... loopy... it feels like the Caron gets a little lost in these glyphs?

Screen Shot 2022-10-06 at 3 44 14 PM
lilasymons commented 2 years ago

Should the Caron.titl be the same as the Tcaron, in regards to the diacritics? Have the same question for the dacron.titl

Screen Shot 2022-10-06 at 3 45 14 PM
lilasymons commented 2 years ago

Should the gcommaaccent.titl be the same as Gcommaaccent.titl?

Screen Shot 2022-10-06 at 3 48 02 PM
vv-monsalve commented 2 years ago

Yes, please go ahead.

vv-monsalve commented 1 year ago

Hi @lilasymons. You had closed this issue, so it seems you consider the job listed in this Issue done; I'm happy to hear that.

If that's the case, please create a new PR to update the source files in the repo so we can run a new QA round.

I've reopened the issue while we continue performing the QA checks to centralize any related feedback here.

lilasymons commented 1 year ago

Hey @vv-monsalve, Is there a proof you want me to use to prepare for the next QA round?

vv-monsalve commented 1 year ago

As we talked about in the meeting, we are using Diffenator2. However, it will create proofs like the ones shown above. It doesn't cover things like Stylistic Sets or OT features. When working don't the fonts you can create and provide documents to test the latter and other important things for the project.

vv-monsalve commented 1 year ago
  • Diacritics for SS

The accented letters should be included in the features for Stylistic Sets. Please review the issue for SS #14

[ ] Kerning

The kerning job is pending. Please review the new separated issue opened for kerning #15

For dcaron.ss03/lcaron.ss03/tcaron.ss03 should those glyphs be substituted for something less... loopy... it feels like the Caron gets a little lost in these glyphs?

Please review and adjust the shape of the caron letters to be more consistent with the stylistic sets (e.g. dcaron.ss03 has completely lost the loop, or terminal strokes in .ss04 are more puffed and rounded). Also, the caron should be closer to the letter, and the spacing needs to be adjusted.

Screen Shot 2023-08-03 at 11 28 09 Screen Shot 2023-08-03 at 11 28 21 Screen Shot 2023-08-03 at 11 28 34 Screen Shot 2023-08-03 at 11 28 44 Screen Shot 2023-08-03 at 11 28 58