L1 Mastering Font checklist

vv-monsalve commented 3 years ago

Diacritics

[x] Inspect the font and choose the best version of the diacritics (in terms of balance, weight, size, contrast) and move them to comb mark.
[x] Adjust left and right sidebearings of all the comb marks to 0.
[x] Work on the selected diacritics to ensure the balance among all marks (contrast, weight, size, stroke or others)
[x] Ensure the consistence among related marks, see issue of reference.
[x] Adjust position, weight, or outlines of the diacritics if needed to, without changing the design of them, and using glyphs app locked guidelines.
[x] Decomposed transformed components, review proportions ensuring round coordinates.
[x] Test the comb marks by inspecting all of them in context (right-click and choose all glyphs using this component).
[x] Inspect and balance the below marks (size, weight, balance) e.g. ogonek cedilla to avoid huge marks
[x] Create Catalan Punt Volat
[x] Delete the legacy marks and add them back so they are made from comb marks.
[x] Create comb.case marks by making them less tall and less narrow while keeping them at the same weight (preferable at the height they are intended to use, to be able to inspect them in their context)
[x] Create the Vietnamese mark.
[x] Make compound glyphs for the entire font.
[x] Adjust the anchor position.
[x] Run the automatic Glyphsapp command: update glyph info.

Glyphs & Outlines

[x] Create the missing glyphs needed.
[x] Run the automatic Glyphsapp commands: Add extremes; cubic curves; correct outlines direction; tidy up paths; round coordinates; remove PS Hint
[x] Check kerning and spacing by using the txt files. Fix any kerning and spacing errors if needed for the most common kerning pairs.
[x] Check terminal forms spacing avoids crashes or collisions. Issue of reference
[x] Run the automatic Glyphsapp command: Resolve all metrics to update the metrics in the entire font.
[x] Check everything once again by going glyph by glyph.
[x] Run the automatic Glyphsapp Update Glyph Info command to avoid bad names issues
[x] Run the automatic Glyphsapp Convert to cubic command to avoid qcurves
[x] @ ¿? ¡! ”” «» position, spacing is good
[x] Lining figures based of main ones + spacing + kerning

OT Features

[x] Check OpenType features and see if all listed are valid, e.g. if .fina glyphs are actually ending shapes or ss are not repeated under different names.
[x] Create Lookup for positional alternates for fina and init cases
[x] Inspect if Stylistic Sets have the right name or rename .001 etc... glyphs and generate the automatic OpenType code.
[x] Check if there is a stylistic set that would correspond to SmallCaps feature instead and change it.
[x] Check if the OpenType code has any error.
[x] Hit the update & compile buttons to check everything is working well.

Testing changes

[x] Inspect the font created by the CI GHA to check production errors. If the action isn't included yet in the repo, export and test the font using Glyphs.
[x] Check the before and after font using gen-html diff if needed (for update font cases)
[x] Check the font on gen-html proof to see if it's working well on web. Use the --imgs flag to produce images.
[x] Commit and make PR using images.

vv-monsalve commented 3 years ago

Hi @crystaltype,

There are some issues in the latest file regarding marks

[x] Inconsistencies among them, both in weight (circumflex tilde) and style. dieresis is more rounded than apostrophe.alt and some terminations are more pointy than others. If the rounded termination is more coherent with the letters, the contrast and weight need to be adjusted.
[x] Marks in the weight Light look heavy for the base letters. Particularly the ones that look heavier and more rounded. E.g. circumflex.
[x] Mark to mark horizontal alignment, e.g. dieresismacron and distance seems a little bit loose, particularly in brevehookabove
[x] Marks look too much to the right in Capital O, and perhaps closer to it than in e.g. A

vv-monsalve commented 3 years ago

PS. Please check the boxes in the issue for the tasks completed

googlefonts / qwitcher-grypen