search

googlefonts / roboto-2

The Roboto family of fonts
Apache License 2.0
3.85k stars 309 forks source link

Lj / LJ Nj / NJ case-sensitivity issue #234

Open erinmclaughlin opened 7 years ago

erinmclaughlin commented 7 years ago

This issue still appears to be unresolved. https://github.com/google/roboto/issues/55

As I understand it, I am unable to run 'make' on my Mac because it isn't recognizing case-sensitivity in glyph names.

File "/Users/erinmclaughlin/env/lib/python2.7/site-packages/ufo2ft/outlineOTF.py", line 895, in setupTable_CFF glyph = self.allGlyphs[glyphName] KeyError: 'Lj'

I believe that Lj and Nj are being confused with LJ and NJ.

Could a new naming scheme be adopted so that these glyphs won't require a crazy work-around?

Thanks, Erin

Edit -- So I was going to rename (or delete) the Lj and Nj glyphs as a workaround, which I have done before, but it appears that they are no longer in the font (??!) -- Yet I still received the error above. Any ideas on how to fix this and why Lj is still coming up as an issue?

m4rc1e commented 7 years ago

Hey Erin,

I'll see what I can do here. I've hit the same issue.

moyogo commented 7 years ago

BTW https://github.com/google/roboto/issues/55#issuecomment-264672901 says how one can build Roboto fonts on Mac.

m4rc1e commented 7 years ago

@moyogo thank you! I'm building from Ubuntu now.

I still think there shouldn't be a workaround for this.

davelab6 commented 7 years ago

I agree. I'm confused by this because I thought UFO file naming with underscores prevented this 😂

On Mar 14, 2017 9:42 AM, "Marc Foley" notifications@github.com wrote:

@moyogo https://github.com/moyogo thank you! I'm building from Ubuntu now.

I still think there shouldn't be a workaround for this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/roboto/issues/234#issuecomment-286424404, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9yxr8YbulYrV095hqeXMQK3W1ch2Lks5rlplWgaJpZM4MNt-- .

m4rc1e commented 7 years ago

I can make the fonts perfectly on Ubuntu 14.04. I'll see what the differences are.

anthrotype commented 7 years ago

the problem is robofab, you should replace it with defcon

davelab6 commented 7 years ago

@m4rc1e this seems important to fix before anything else :)

m4rc1e commented 7 years ago

@davelab6 if we use @anthrotype's suggestion, we'll need to test the fonts thoroughly, write some regression unit tests and cut a new release.

davelab6 commented 7 years ago

Yes. Is the problem that on Mac OS X the file system is case insensitive, and the robofab glif file naming scheme doesn't account for that correctly, but the defcon glif naming scheme does?

m4rc1e commented 7 years ago

@davelab6 I've had this problem with other chains involving Robofab. I can confirm that more modern build tools such as Fontmake don't suffer with this issue.