googlefonts / roboto-2

The Roboto family of fonts
Apache License 2.0
3.85k stars 309 forks source link

Requires Python 2, not 3. #257

Closed SimonBiggs closed 7 years ago

SimonBiggs commented 7 years ago

It appears that roboto dependencies currently require Python 2. In particular https://github.com/robofab-developers/robofab.git@62229c4ea33c324e698766d3700ca9a47efcdeb6 .

Collecting git+https://github.com/robofab-developers/robofab.git@62229c4ea33c324e698766d3700ca9a47efcdeb6 (from -r requirements.txt (line 11))
  Cloning https://github.com/robofab-developers/robofab.git (to 62229c4ea33c324e698766d3700ca9a47efcdeb6) to /tmp/pip-xnipby8r-build
  Could not find a tag or branch '62229c4ea33c324e698766d3700ca9a47efcdeb6', assuming commit.
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-xnipby8r-build/setup.py", line 15
        print "*** Warning: FontTools needs the numpy library for some operations, see:"
                                                                                       ^
    SyntaxError: Missing parentheses in call to 'print'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-xnipby8r-build/
m4rc1e commented 7 years ago

We recommend installing the dependencies with a virtualenv

virtualenv roboto-env

On Mac OS X, Python 2.7 is still the default for creating new virtualenvs, if a Python version isn't specified. Is this still the case for distros of Linux?

SimonBiggs commented 7 years ago

I was running Ubuntu 17.04 at the time I wrote that pull request. I have since reverted to 16.04 so I won't be able to confirm for you.

My system defaulted to Python 3 with the virtual env, but that could have been my own settings. I thought the note about requiring Python 2 would be helpful nevertheless.

m4rc1e commented 7 years ago

@SimonBiggs this confirms my suspicions. I remember Ubuntu changed the default Python to 3+ after Ubuntu 14.04.

davelab6 commented 7 years ago

This pr could probably go further and use the explicit v2 commands for systems have that both installed v2 and v3

On Jul 7, 2017 5:04 AM, "Marc Foley" notifications@github.com wrote:

@SimonBiggs https://github.com/simonbiggs this confirms my suspicions. I remember Ubuntu changed the default Python to 3+ after Ubuntu 14.04.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/roboto/pull/257#issuecomment-313628668, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y6OoW7zvg_Y7zP3MBcwAYM3KFuatks5sLfSlgaJpZM4Nvnc8 .

davelab6 commented 7 years ago

Thanks @SimonBiggs :)

SimonBiggs commented 7 years ago

You're very welcome. And thank you for your work :).