search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
153 stars 15 forks source link

Add first 32 control chars #100

Closed m4rc1e closed 2 years ago

m4rc1e commented 2 years ago

As requested by the Android team. Supersedes #96, Fixes #98, #99

@chrissimpkins. Once the CI is done making the fonts, I'll post the link so the team can test.

m4rc1e commented 2 years ago

Just like to point out that these characters are only getting added to the Android cut. They're being mapped to the first empty glyph in the font.

m4rc1e commented 2 years ago

@chrissimpkins here's a link to the generated fonts, https://github.com/googlefonts/roboto-classic/suites/7273375516/artifacts/292791016

m4rc1e commented 2 years ago

Here's a diffenator2 report (tool still wip)

report.zip

We can see that the cmap has been changes as expected.

Screenshot 2022-07-08 at 12 22 11
chrissimpkins commented 2 years ago

Thanks Marc! I will reach out to the team to confirm that this works for them and discuss the next step.

m4rc1e commented 2 years ago

Thanks! I'll be away from today until the 20th of July so if the team is happy, you may need to find someone (or yourself) to cut a release. It's fairly straight forward, you can create a release using the github gui and just attach the fonts generated by the ci.

chrissimpkins commented 2 years ago

I reached out to Android team today to followup on this request. We are waiting on confirmation that this addresses the issue.

cc @RosaWagner

davelab6 commented 2 years ago

I believe the customer team accepted this, so can be merged

m4rc1e commented 2 years ago

Cool. I'll merge this and then add #97 and cut a new release.

chrissimpkins commented 2 years ago

Thanks Marc!