googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
153 stars 15 forks source link

*.ufo.features.fea: add sups and subs features #101

Closed m4rc1e closed 2 years ago

m4rc1e commented 2 years ago

Fixes #97

@kpozin once the ci has finished genning the fonts, I'll pass a link over. I've had a quick look myself and they're working well.

m4rc1e commented 2 years ago

Ok, the ci has finished. Font can be downloaded from https://github.com/googlefonts/roboto-classic/suites/7541190063/artifacts/311024320

Can confirm sub and sups features are now working:

hb-shape Roboto\[ital\,wdth\,wght\].ttf --features sups 0123456789
[zerosuperior=0+751|onesuperior=1+751|twosuperior=2+751|threesuperior=3+751|uni2074=4+751|fivesuperior=5+751|sixsuperior=6+751|sevensuperior=7+751|eightsuperior=8+751|ninesuperior=9+751]

hb-shape Roboto\[ital\,wdth\,wght\].ttf --features subs 0123456789
[zerosub=0+751|oneinferior=1+751|twosub=2+751|threesub=3+751|foursub=4+751|fivesub=5+751|sixinferior=6+751|sevensub=7+751|eightsub=8+751|nineinferior=9+751]

Test have also been added to ensure these features exist in future releases.

kpozin commented 2 years ago

Looks great. Thank you!

davelab6 commented 2 years ago

Thanks all

m4rc1e commented 2 years ago

v3.005 which includes this fix has been cut https://github.com/googlefonts/roboto-classic/releases/tag/v3.005