googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
151 stars 15 forks source link

Fea fix anchors v2 #11

Closed cjdunn closed 6 years ago

cjdunn commented 6 years ago

–started from previous commit before anchor modifications: https://github.com/TypeNetwork/Roboto/commit/0a0fd4621fa564a0abf8a33227b1c88820c3424c –ran a modified version of the fixAnchors script from Marc, which runs directly in RoboFont without dependencies. –rebuilt var font –added both versions of the fixAnchors script

m4rc1e commented 6 years ago

Looks great!

Diffenator

Roboto-Regular.ttf vs Roboto-Regular.ttf

attribs 1 modified

table attrib value_a value_b
head modified 2016/12/15 22:52:08 2018/06/26 16:28:46

mkmks 42 modified

mark1_glyph mark2_glyph diff_x diff_y
uni1ABC commaturnsupnosp -47.0 406.0
uni1ABB commaturnsupnosp -47.0 406.0
uni1ABC commasuprevnosp 24.0 406.0
uni1ABB commasuprevnosp 24.0 406.0
uni1ABC uni0313 -23.0 406.0

mkmks 180 missing

mark1_glyph mark2_glyph mark1_x mark1_y mark2_x mark2_y
acutesubnosp cedilla -607 0 213 -440
acutesubnosp commaaccent -607 0 256 -162
acutesubnosp ogonek -607 0 306 -434
archdblsubnosp ogonek -585 0 306 -434
archdblsubnosp commaaccent -585 0 256 -162

names 1 modified

id string_a string_b
(3, 3, 1, 1033) Google:Roboto Regular:2016 Google:Roboto Regular:2017

glyphs 23 modified

glyph diff
uni1AB5 5577.0
uni047A 1869.08333333
uniFFFC 1280.0
threeeighths 1112.58333333
uni20BA 1056.79166667
m4rc1e commented 6 years ago

Feel free to merge this pr and close all the others.

cjdunn commented 6 years ago

@m4rc1e Glad to hear this is all resolved! Please let me know if anything else comes up. /cc @davelab6 @sberlow

davelab6 commented 6 years ago

Great work CJ and Marc!! :D