Roboto-min.designspace: Added map elements to each axis

[m4rc1e]

I've added map elements to each axis in the designspace. By doing this, we now get an avar table

Fixes #12

Map elements weren't needed in the Roboto.designspace (uses every style as a source). Once I'm confident Roboto-min.designspace is fine, I think we should drop this designspace.

@anthrotype apologies but it would be great to get a review on this. I come from a glyphsapp background so these designspaces were always taken care of for me.

cc @cjdunn @davelab6

[m4rc1e]

ps After #11 this will now gen with the latest pip fontmake

[anthrotype]

I’m back on the 2nd of July, I’ll take a look then.

[m4rc1e]

Thanks man! apologies for disturbing you. Enjoy your break!

[davelab6]

Map elements weren't needed in the Roboto.designspace (uses every style as a source). Once I'm confident Roboto-min.designspace is fine, I think we should drop this designspace.

Dropping the Roboto.designspace now that you've proven Roboto-min.designspace matches it 1:1 100% would be great :)

[davelab6]

@cjdunn @sberlow to confirm, I'd like to wait on merging this until @anthrotype gets a change to review.

@m4rc1e please could you add to this PR the resulting TTF binary that you get when the above is applied, plus the test pages you are using, so that other interested folks can take a look at the diff that remains?

[anthrotype]

I see this repo also contains some scripts to generate the designspace files: Scripts/writeDesignSpace.py and Scripts/writeDesignSpace-min.py

Shouldn't those be updated to match the changes in this PR or removed if they are no longer used?

https://github.com/TypeNetwork/Roboto/blob/3580c804906528102360f25691cdc275f83fdb7d/Scripts/writeDesignSpace-min.py#L27

[m4rc1e]

@anthrotype I'll update the script. Thanks

[m4rc1e]

Doh, the designspace gen scripts in https://github.com/TypeNetwork/Roboto/tree/master/Scripts didn't produce the designspaces we currently have in the master (may just be different ordering)

Since designspaces are xml, we should just drop the gen scripts (xml is more readable than a script imo)

[petrvanblokland]

Wether DDSD-XML or scripts are more simple depends very much on the complexity and topology of the design space. There can be intended redundancy and rendered values created, not obvious visible in the XML, that are easily commented in scripts. Also the amount of axes and masters plays a role to choose for one or the other.

I agree that the script should be up to date, but without them and without a topology drawing of the design space, the XML may not be as readable for the big picture. I'd suggest to bring them up to date and document well what kind of space they are generating.

On Jul 2, 2018, at 6:47 PM, Marc Foley notifications@github.com wrote:

Doh, the designspace gen scripts in https://github.com/TypeNetwork/Roboto/tree/master/Scripts https://github.com/TypeNetwork/Roboto/tree/master/Scripts didn't produce the designspaces we currently have in the master.

Since designspaces are xml, we should just drop the gen scripts (xml is more readable than a script imo)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/Roboto/pull/13#issuecomment-401865799, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXBwf6LlbE6SMSgcigSJYGwAynrZQ_kks5uCk6HgaJpZM4U7hIq.

---

Petr van Blokland | twitter+skype @petrvanblokland Intentionally not on FaceBook since 1998 buro@petr.com | typetr.typenetwork.com mobile +31 6 24 219 502 | buro +31 15 887 1233

designdesign.space upgrade.typenetwork.com bitcount.typenetwork.com

Rietveld 56 2611 LM Delft The Netherlands

Claudia Mens | claudia@petr.com mobile +31 6 41 367 689 | buro +31 15 887 1233

[m4rc1e]

Something really strange has happened to my fork. When we made the repo public, I also made my fork public. Since then my fork is no longer a fork :-(. I'll try and rectify this now.

I've updated the designspace scripts. I'll get them pushed once I'm back.