search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
154 stars 15 forks source link

Composites are blank #59

Closed m4rc1e closed 4 years ago

m4rc1e commented 4 years ago

In branch delivery-review. The composites are not showing

Screenshot 2020-03-19 at 12 18 55

It may be the vttLib transfer or the maxp step which is causing this.

m4rc1e commented 4 years ago

Ok, the VTT source, https://github.com/TypeNetwork/Roboto/blob/delivery-review/HintingSource/VTTSourceRoboto-min-VF.ttf has the same issue.

If I check Mike's original hinted source, https://github.com/TypeNetwork/Roboto/blob/master/Hinted%20VTT/MD%20Hints/Sources/RobotoVTTSources/VTTSourceRoboto-min-VF.ttf it also has the same issue. Please update the hint source so the composites are hinted. This shouldn't been too difficult to do.

sannorozco commented 4 years ago

Hallo Mark,

These blank composites are the ones we removen in our “diet” test for Harfbuzz, so this is intentional.

On Thu 19 Mar 2020 at 6:34 Marc Foley notifications@github.com wrote:

Ok, the VTT source, https://github.com/TypeNetwork/Roboto/blob/delivery-review/HintingSource/VTTSourceRoboto-min-VF.ttf has the same issue.

If I check Mike's original hinted source, https://github.com/TypeNetwork/Roboto/blob/master/Hinted%20VTT/MD%20Hints/Sources/RobotoVTTSources/VTTSourceRoboto-min-VF.ttf it also has the same issue. Please update the hint source so the composites are hinted. This shouldn't been too difficult to do.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/Roboto/issues/59#issuecomment-601153074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJBDGCIICO2T7RWTV3OHELRIIGMJANCNFSM4LPHVBIQ .

-- Santiago Orozco Typemade

m4rc1e commented 4 years ago

ok cool :-)

If we do include a diet build, why not just use pyftsubset at the end to remove all the composites? This way we won't need seperate sources for diet and non-diet.

tbh, I don't think this build diet is going to work. I can see it failing in many situations and we'll end up with another Montserrat gate. Anyways, that's a discussion for another issue.

For the delivery-review branch, I'd like us to use the non-diet files.

dberlow commented 4 years ago

The composite situation can be changed.

When it was suggested we do this, we suggested it be done by subsetting afterwards, as needed.

To back up, put the composites back in, and make either a build without them, or a build they can be subset out of, may take a few work days, and we'll start at 9:30 with a meeting on it.

Thanks..

On Thu, Mar 19, 2020 at 8:37 AM Santiago Orozco notifications@github.com wrote:

Hallo Mark,

These blank composites are the ones we removen in our “diet” test for Harfbuzz, so this is intentional.

On Thu 19 Mar 2020 at 6:34 Marc Foley notifications@github.com wrote:

Ok, the VTT source,

https://github.com/TypeNetwork/Roboto/blob/delivery-review/HintingSource/VTTSourceRoboto-min-VF.ttf has the same issue.

If I check Mike's original hinted source,

https://github.com/TypeNetwork/Roboto/blob/master/Hinted%20VTT/MD%20Hints/Sources/RobotoVTTSources/VTTSourceRoboto-min-VF.ttf it also has the same issue. Please update the hint source so the composites are hinted. This shouldn't been too difficult to do.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/TypeNetwork/Roboto/issues/59#issuecomment-601153074 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAJBDGCIICO2T7RWTV3OHELRIIGMJANCNFSM4LPHVBIQ

.

-- Santiago Orozco Typemade

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/Roboto/issues/59#issuecomment-601154285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO5VDWLONFXZRXBHBLN6LTRIIGXJANCNFSM4LPHVBIQ .