search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
151 stars 15 forks source link

STAT table is incorrect #63

Closed m4rc1e closed 4 years ago

m4rc1e commented 4 years ago

Each instance has the ElidableAxisValueName flag set and they all have linked values.

Please see how the ElidableAxisValueName and linked values are used in this .stylespace

sannorozco commented 4 years ago

Updated

vitorsr commented 1 year ago

@m4rc1e, sorry for replying to a closed issue but I did not want to open a new one.

I believe there are still inconsistencies with the STAT table, namely a named SemiBold weight instance present in fvar that overlaps with the Medium weight definition in STAT.

    <!-- SemiBold -->
    <!-- PostScript: Roboto-SemiBold -->
    <NamedInstance flags="0x0" postscriptNameID="302" subfamilyNameID="264">
      <coord axis="wght" value="600.0"/>
      <coord axis="wdth" value="100.0"/>
      <coord axis="ital" value="0.0"/>
    </NamedInstance>
      <AxisValue index="6" Format="2">
        <AxisIndex value="1"/>
        <Flags value="0"/>
        <ValueNameID value="263"/>  <!-- Medium -->
        <NominalValue value="500.0"/>
        <RangeMinValue value="450.0"/>
        <RangeMaxValue value="650.0"/>
      </AxisValue>

In the build script, the STAT is generated with gen_stat.py.

In addition, I believe it would be best if the Roman 'ital' variation had a linked value for style mapping.

I am not sure if either was intentional or not, so please forgive my not knowing.