search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
151 stars 15 forks source link

Fea add class kerning #8

Closed cjdunn closed 6 years ago

cjdunn commented 6 years ago

–imported class kerning from TTFs –removed redundant kerning exceptions -rebuilt var font

m4rc1e commented 6 years ago

@cjdunn I'll give this a check now.

m4rc1e commented 6 years ago

I just checked out the pr and genned some static ttfs and diffed them against v2.136. The kerns are perfect!

Diffenator

Roboto-Regular.ttf vs Roboto-Regular.ttf

attribs 1 modified

table attrib value_a value_b
head modified 2016/12/15 22:52:08 2018/05/10 09:16:51

metrics modified No differences

kern new No differences

kern modified No differences

kern missing No differences

names new No differences

names 1 modified

id string_a string_b
(3, 3, 1, 1033) Google:Roboto Regular:2016 Google:Roboto Regular:2017

names missing No differences

marks new No differences

marks 1 modified

base_glyph mark_glyph diff_x diff_y
a_uni02DE gravecomb -330.0 -2.0

marks 5628 missing

base_glyph mark_glyph base_x base_y mark_x mark_y
zrthook gravesubnosp 502 -447 -583 0
zrthook uni0315 1120 1290 -88 1066
zdotaccent uni035D 1016 1600 0 1162
zdotaccent uni035C 1016 -407 0 -40
zdotaccent uni1ABB 515 1290 -558 1350

glyphs new No differences

glyphs 23 modified

glyph diff
uni1AB5 5577.0
uni047A 1869.08333333
uniFFFC 1280.0
threeeighths 1112.58333333
uni20BA 1056.79166667

glyphs 18 not accessible

glyph --- | uni0069.ccmp uni006A.ccmp uni012F.ccmp uni0249.ccmp uni0268.ccmp

This pr can be merged.

I will look into what is causing the missing marks and inaccessible glyphs today.

Thanks @cjdunn this great

justvanrossum commented 6 years ago

Is this "Diffenator" output from a publically available tool? Looks super useful.

m4rc1e commented 6 years ago

@justvanrossum its still a WIP https://github.com/googlefonts/fontdiffenator/tree/rm-ttxn. We're currently updating several large families so I'm developing this differ at the same time, it still needs some work. It takes into account differences such as changing a font's upm, changing glyph names to uniXXXX etc. Atm, I don't publicly advertise it because it still produces a lot of noise.

justvanrossum commented 6 years ago

Thanks!

davelab6 commented 6 years ago

@m4rc1e should this PR be closed, or, what's next to move it forwards?

davelab6 commented 6 years ago

Hmm https://github.com/TypeNetwork/Roboto/issues/4#issuecomment-398826326 says

We need to merge #8 - the kerning issue is now solved.

Can this be merged now, then?