search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
150 stars 15 forks source link

Update fontinfo.plist #82

Closed sannorozco closed 3 years ago

sannorozco commented 3 years ago

fixed condensed-lightitalic plist conflict

m4rc1e commented 3 years ago

@sannorozco This PR does fix #81 however, what has changed since the last tagged commit, 8fd92361e85f031342493ce6994bf7e5ee6a08f5?

There's over half a million changes since the above commit. I'm guessing some of these changes were unintentional and introduced by opening and saving the ufos in robotofont? if that's the case, we need to run the ufos through ufoNormalizer.

We've spent months getting the files into a position where we are semi confident that they're regression free. I'm hesitant to accept the latest commits.

m4rc1e commented 3 years ago

What's up with the dir https://github.com/TypeNetwork/Roboto/tree/master/sources/Berlow's%20Math%20ideal%20corrections? If this work isn't merged into the ufos, it should've just been done on a sep branch.

sannorozco commented 3 years ago

Hallo @m4rc1e,

All the commits after your latest tagged release were not intentional, and were in response to the math glyphs issue, we were so eager to fix them that we made some mistakes, e.g. moving ufos to the dir you point at, causing the large amount of changes. We’re sorry for this confusion and we’ll be working on the “NeoClassic” branch from now on, and we’ll PR for your approval. This won’t happen again.

All these commits can be discarded and we can roll back to your last tagged commit 8fd9236

The dir you point out can be removed.

Please let me know how to proceed.