search

googlefonts / roboto-classic

Development of a Roboto Variable font
SIL Open Font License 1.1
150 stars 15 forks source link

Mark glyphs with incorrect contour directions #86

Closed m4rc1e closed 3 years ago

m4rc1e commented 3 years ago

If a mark glyph is used a component in another glyph and its contour orientation differs from the base glyph, the marks will appear lighter in OS X. For this family, I can see that the double grave accent's has this issue (there may be more).

roboto1

Ȑ double grave appears lighter. Issue also happens in Ѷ ѷ Ȁ ȁ Ȅ ȅ Ȉ ȉ Ȍ ȍ Ȑ ȑ Ȕ ȕ Ȕ

To solve this issue, we must do the following:

Imo this is a blocker and we must solve this issue before we can release the family. We discovered this issue whilst reviewing Asap, https://github.com/TypeNetwork/Asap/issues/6

cc @davelab6 @dberlow @moyogo

dberlow commented 3 years ago

According to the sources, (U+030F) reversal includes Roman and italic.

mikedug commented 3 years ago

the contours for (U+030F) , compared to Unicode 0210, look to be the same orientation in VTT in the Roboto Variable. Am I missing something?[] 0X30F (url)

m4rc1e commented 3 years ago

the contours for (U+030F) , compared to Unicode 0210, look to be the same orientation in VTT in the Roboto Variable. Am I missing something?[]

If we inspect uni210, the base component "R" is anticlockwise, whilst the mark component "double tilde" is clockwise.

mikedug commented 3 years ago

ok, thanks. I see the R as clockwise and the accent as anti-clockwise, in the illustration above.

davelab6 commented 3 years ago

But, either way, they are opposite directions, but they should be the same directions.

@m4rc1e please can you file a fontbakery issue to check for this, and fix Roboto directly.

dberlow commented 3 years ago

If these need to be fixed by FB, let me know.

On Thu, Nov 12, 2020 at 10:44 AM Dave Crossland notifications@github.com wrote:

But, either way, they are opposite directions, but they should be the same directions.

@m4rc1e https://github.com/m4rc1e please can you file a fontbakery issue to check for this, and fix Roboto directly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/Roboto/issues/86#issuecomment-726159244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO5VDTU2DZOHCDDDRCWUE3SPP7GBANCNFSM4TR6OGWA .

davelab6 commented 3 years ago

I believe this is a minor production issue, which will take Marc 4-8 hours to do, and so with other high priority FB projects going on, its best for Marc to do :)