font is not seen as monospaced by putty on windows

googlefonts / roboto

The Roboto family of fonts

Apache License 2.0

3.84k stars 308 forks source link

font is not seen as monospaced by putty on windows #300

Open mailinglists35 opened 5 years ago

mailinglists35 commented 5 years ago

to load in putty i must enable the option window-appearance - allow selection of variable pitch fonts

please make the font truly monospaced

thanks

mailinglists35 commented 5 years ago

https://github.com/google/fonts/issues/225

mailinglists35 commented 5 years ago

https://github.com/google/fonts/issues/251

sladen commented 5 years ago

Hello @mailinglists35, thank you for the various comments.

Think this was stuck on confirming precisely why the fonts were not be recognised, with the candidates being both the PANOSE metadata and the isFixedPitch flag itself. Have you been able to confirm which of those solves the issue of Putty not finding/using the fonts?

This is the setting of the 'isFixedPitch flag on Roboto

sladen commented 5 years ago

PuTTY code is at:

https://github.com/github/putty/blob/master/windows/winctrls.c#L2501 which does: dp->fixed_pitch_fonts = !(GetTextMetrics(GetDC(NULL), SelectObject(GetDC(NULL), CreateFont())).tmPitchAndFamily & TMPF_FIXED_PITCH);

sladen commented 5 years ago

Don't have the MS Windows source code, but the Wine implementation (which uses Freetype) populates this field in:

https://github.com/wine-mirror/wine/blob/master/dlls/gdi32/freetype.c#L7892

with:

 FT_IS_FIXED_WIDTH(ft_face);
 pOS2->panose[PAN_PROPORTION_INDEX] == PAN_PROP_MONOSPACED;

mailinglists35 commented 5 years ago

ave you been able to confirm which of those solves the issue of Putty not finding/using the fonts?

@sladen forgive me, I am just an innocent end-user: I see a nice font, I click it, I see it available in putty.

It is a bit difficult for me to compile stuff, but I can happily try a ttf file if someone can build versions with various flags enabled/disabled.

I could blindly monkey-paste some ubuntu or fedora build instructions as long as they are idiot-proof.

mailinglists35 commented 5 years ago

@sladen I cloned the repo but I can't find string isFixedPitch in the sources. neither PANOSE - where do I modify and what?