googlefonts / rubik

Rubik fonts
SIL Open Font License 1.1
200 stars 45 forks source link

reconstructed hinting, fixes #15 #17

Closed laerm0 closed 3 years ago

laerm0 commented 6 years ago

This not only fixes #15 but it fixes https://github.com/google/fonts/issues/1137. Or it should anyway: trying to replicate that bug that made the font disappear is not easy. I can't get the fonts to break, but I do think they need a little more testing just to make sure.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


laerm0 commented 6 years ago

I signed it!

m4rc1e commented 6 years ago

I've just generated the fonts from the .glyphs file. Each ttf contains 764 glyphs. However, In the Bold vtt src file there are 770. Imo, they should match.

laerm0 commented 6 years ago

Oh, you're right, I forgot to get rid of a few unnecessary glyphs. I'll remove them and then push a new file this afternoon.

davelab6 commented 3 years ago

Closing as replaced by the VF work