Rubik Cyrillic improvements

googlefonts / rubik

Rubik fonts

SIL Open Font License 1.1

204 stars 46 forks source link

Rubik Cyrillic improvements #4

Closed alexeiva closed 7 years ago

alexeiva commented 8 years ago

see 2_sources/Rubik-Cyrillic for Cyrillic source files
3_test_pdfs/ for Cyrillic test documents

!NB Please do not merge until work on Cyrillic is complete

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

alexeiva commented 8 years ago

@googlebot I confirm the changes are by myself and @m4rc1e. Both authors have signed CLA's

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

alexeiva commented 7 years ago

As @davelab6 suggested, I have absorbed @meirsadan's PR https://github.com/googlefonts/rubik/pull/3 in this PR. There was a .glif naming clash in the UFOs, which I resolved manually in favor of Meir's updated glyphs names.

CONFLICT (rename/rename): Rename "2_sources/Rubik-Black.ufo/glyphs/qamatsqatanhebrew.glif"->"old/version-1/2_sources/Rubik-Black.ufo/glyphs/qamatsqatanhebrew.glif" in branch "HEAD" rename "2_sources/Rubik-Black.ufo/glyphs/qamatsqatanhebrew.glif"->"2_sources/Rubik-Black.ufo/glyphs/qamatshebrew.glif" in "9369945729b55ca93b759e268c07f666b1657385"

davelab6 commented 7 years ago

@alexeiva I assumed this was complete, lmk if not!