googlefonts / science-gothic

Science Gothic, a libre variable font
Other
142 stars 4 forks source link

Generating fonts from Designspace failed: Base master not found. #286

Closed kateliev closed 2 years ago

kateliev commented 2 years ago

This is something odd to investigate. FL builds the font just fine but UFO+fontmake won't.

BUILD >>> Generating Variable Font: ScienceGothic[YOPQ,slnt,wdth,wght].designspace
fontmake: Error: In '..\..\..\..\..\9_Playground\UFO\ScienceGothic\ScienceGothic[YOPQ,slnt,wdth,wght].designspace': Generating fonts from Designspace failed: Base master not found.

Attaching two designspaces to this issue for further checkup: VF built directly from FL: ScienceGothic[YOPQ,slnt,wdth,wght]-FL-Build.designspace.txt

Design space exported from FL and fed to FontMake: ScienceGothic[YOPQ,slnt,wdth,wght]-UFO+Fontmake.designspace.txt

tphinney commented 2 years ago

I did review the existing designspace files and did not see anything obvious. With far fewer predefined instances thanks to #287 , it should be easier to compare designspaces again, next time.

kateliev commented 2 years ago

@tphinney I tried a broad variety of possible fixes and finally removing the anchors did the trick! After all it seems that we might actually have a similar case like https://github.com/googlefonts/fontmake/issues/747

Will investigate further...

kateliev commented 2 years ago

Have written an audit test to investigate the above! Yep that was the issue - inconsistent anchors across different layers. image

kateliev commented 2 years ago

Fixed! Font builds as expected thus closing the issue

The following glyphs had all sorts of anchor issues: /H/J/K/h.sc/k.sc/x.sc/k/p/colonmonetary/uni20B2/Hcircumflex/Hbar/Jcircumflex/uni0408/uni040C/uni041A/uni041D/uni0440/uni0444/uni04A4/uni043D.sc/uni0136/uni0137/hcircumflex.sc/uni1EF4/uni20B2.alt/uni1E85.sc/uni1EAD.sc/uni1EB7.sc/colonmonetary.alt