googlefonts / science-gothic

Science Gothic, a libre variable font
Other
142 stars 4 forks source link

Add African Pri glyph coverage #302

Closed tphinney closed 8 months ago

tphinney commented 10 months ago

(UPDATE: Still a moving target when this was written, check for latest data!)

There are about 32 glyphs defined for this. About 15 are already in the current builds of Science Gothic.

Then there are about 8 that need composite glyphs defined (+4 for small caps)

And about 8 (12 including small caps) that need custom new glyphs made, because they are letters with hooks, which are attached rather than floating.

https://github.com/googlefonts/glyphsets/pull/137

https://docs.google.com/spreadsheets/d/10MQCuYIGBDPqYFr1WEYWvu9Tshk5ASsr25NGVcJksYs/edit#gid=0

chrissimpkins commented 9 months ago

See the latest updates to the glyph set based on feedback from Neil and Denis. https://github.com/googlefonts/glyphsets/pull/137/commits/772fe9c07aab90108d70b2907657975a562b8aff

tphinney commented 9 months ago

@chrissimpkins hmmm. Funny that it has "0x1e63 LATIN SMALL LETTER S WITH DOT BELOW" but not the matching capital letter. I am going to assume that is an error until/unless somebody tells me differently.

tphinney commented 9 months ago

Need to recheck against the latest version of the data

kateliev commented 8 months ago

These are now done!

BUT discussing #309 it just came to me! Currently we are using uniXXXX font naming standard through the typeface, but for the newly generated African glyphs i used friendly names (bit mislead by the google glyphset docs).

image

What shall we do about it: a) keep it as it is; b) change it to uniXXXX;

tphinney commented 8 months ago

Aha. Yeah, so... Glyphs App has a function where one can use Glyphs/friendly names and those get automatically mapped to “proper” glyph names at export time.

So you might think this is bad, these names are not in AGL so they ought to be uniXXXX names in the actual font.

But honestly the cases where glyph names even matter are super corner cases. Mostly for PDF generated from a print stream without a separate font available, and the font is CFF. I am making some inquiries about this, see how much it matters or Google cares about it, in OT-TTF.

tphinney commented 8 months ago

Yeah, the glyph names in OT-TTF don’t even survive on the Google server. They drop glyph names entirely for the version they serve up dynamically!

How much work to change them?

Dave does not think it matters. Let’s see if FontBakery cares. If not, we will leave it as is.

So do a fresh TTF build so we can test this and other things?

tphinney commented 8 months ago

Apparently FontBakery does care. Not sure if it is a WARN or a FAIL. However, I see no warning on this at all from Fontbakery on a font exported directly from FontLab 8.3.

Let’s do a Fontmake based build and also make sure we have the latest Fontbakery, and see what we get.

tphinney commented 8 months ago

Well, I did check with the latest Fontbakery and it seems not to object. I wonder if this might be because the TTF export is dropping glyph names? But in any case we seem to be OK.