search

googlefonts / science-gothic

Science Gothic, a libre variable font
Other
142 stars 4 forks source link

Fontbakery does not like year range in copyright notice #310

Closed tphinney closed 3 weeks ago

tphinney commented 8 months ago

com.google.fonts/check/font_copyright Copyright notices match canonical pattern in fonts with ScienceGothic[YOPQ,slnt,wdth,wght].ttf

More info: https://github.com/googlefonts/fontbakery/pull/2383

 FAIL Name Table entry: Copyright notices should match a                    
      pattern similar to: "Copyright 2019 The Familyname Project Authors    
      (git url)" But instead we have got: "Copyright 2019-2022 The Science  
      Gothic Project Authors.                                               
      https://github.com/tphinney/science-gothic/blob/main/AUTHORS.txt"     
      [code: bad-notice-format]                                             

Result: FAIL
tphinney commented 8 months ago

This seems like an error in Fontbakery. For a font in development for more than a year, I expect it could have multiple years in the copyright notice. One sees such copyright notices all the time. Fontbakery should accept any mix of single years and year ranges. For example this should be considered valid:

"Copyright 2017-19, 2021, 2022-24 The Familyname Project Authors (git url)"

tphinney commented 7 months ago

I filed an issue against Fontbakery at the time: https://github.com/fonttools/fontbakery/issues/4386

Seems like it may be loosened so as to be a WARN rather than a FAIL, which would be good enough for me.

tphinney commented 3 weeks ago

Dave tells me that Google legal folks want it as a single (most recent) year. I have changed it in source.