search

googlefonts / science-gothic

Science Gothic, a libre variable font
Other
142 stars 4 forks source link

Vertical metrics need revision #317

Closed tphinney closed 3 weeks ago

tphinney commented 7 months ago

FontBakery report:

Check font follows the Google Fonts vertical metric schema Check ID: com.google.fonts/check/vertical_metrics This check generally enforces Google Fonts’ vertical metrics specifications. In particular: lineGap must be 0 Sum of hhea ascender + abs(descender) + linegap must be between 120% and 200% of UPM * Warning if sum is over 150% of UPM

The threshold levels 150% (WARN) and 200% (FAIL) are somewhat arbitrarily chosen and may hint at a glaring mistake in the metrics calculations or UPM settings.

Our documentation includes further information: https://github.com/googlefonts/gf-docs/tree/main/VerticalMetrics

🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1900 when it should be at least 2400 [code: bad-hhea-range]

OLD vertical metrics

Screenshot 2024-01-03 at 6 40 33 PM

NEW vertical metrics

TBD if this resolves the error message

Screenshot 2024-01-03 at 6 41 18 PM
tphinney commented 3 weeks ago

Fixed with f6c1ebe3a15440e20474d257af518e8d52e3ccc2