search

googlefonts / science-gothic

Science Gothic, a libre variable font
Other
142 stars 4 forks source link

Linegap should be zero #336

Closed tphinney closed 3 weeks ago

tphinney commented 2 months ago

Checking Vertical Metric Linegaps. Check ID: <FontBakeryCheck:com.google.fonts/check/linegaps> The LineGap value is a space added to the line height created by the union of the (typo/hhea)Ascender and (typo/hhea)Descender. It is handled differently according to the environment.

This leading value will be added above the text line in most desktop apps. It will be shared above and under in web browsers, and ignored in Windows if Use_Typo_Metrics is disabled.

For better linespacing consistency across platforms, (typo/hhea)LineGap values must be 0.

Original proposal: https://github.com/fonttools/fontbakery/issues/4133 See also: https://googlefonts.github.io/gf-guide/metrics.html 🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf 🔥 FAIL OS/2 sTypoLineGap is not equal to 0.

Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, all messages from this check are considered FAILs.

[code: OS/2]

tphinney commented 3 weeks ago

Fixed in f6c1ebe3a15440e20474d257af518e8d52e3ccc2