googlefonts / sfntly

A Library for Using, Editing, and Creating SFNT-based Fonts
451 stars 162 forks source link

Fix 'INCLUDE WHAT YOU USE' violation #73

Closed jungshik closed 7 years ago

jungshik commented 7 years ago

UnicodeString and U_* are used without including any ICU headers. This used to work with ICU 58.x, but not any more with ICU 59-to-be.

This change is necessary for upgrading Chrome's ICU to 59.x. ( https://crbug.com/699469 )

Will fix #72

jungshik commented 7 years ago

@behdad , can you take a look? I need this change to test upgrading ICU to 59.x in chromium. Thanks.

jungshik commented 7 years ago

Thanks, @behdad