Closed bobh0303 closed 2 months ago
For fa_Arab
I get other kinds of messages related to previously reported missing base chars:
Font does not fully support language 'fa_Arab'
* FAIL: Some base glyphs were missing: چ
* FAIL: Shaper produced a .notdef
* FAIL: .fina version of ARABIC LETTER TCHEH; both buffers returned .notdef=1+1033|space=0+0
* FAIL: Shaper didn't attach uni064B to None
* FAIL: Shaper produced a .notdef
* FAIL: Shaper didn't attach uni064D to None
* FAIL: Shaper produced a .notdef
* FAIL: Shaper didn't attach uni064C to None
* FAIL: Shaper produced a .notdef
* FAIL: Shaper didn't attach uni0651 to None
* FAIL: Shaper produced a .notdef
* FAIL: Shaper didn't attach uni0654 to None
* FAIL: Shaper produced a .notdef
...
Thanks for re-filing this here; I'll work on it.
When font is missing a character needed for a particular language, one output message is sufficient. Subsequent tests that depend on that character needn't be run.
Example:
Only the first Fail is needed — all the rest are redundant.
Test info:
Command:
shaperglot check Alkalami-Regular.ttf ur_Arab
Font download: https://software.sil.org/alkalami/download/System info:
Python 3.10.12 shaperglot: 0.5.0 Ubuntu: 22:04
Replaces fonttools/fontbakery#4654