googlefonts / staatliches

Herbert Bayer’s title lettering for the first Bauhaus exhibition catalogue cover of 1923
SIL Open Font License 1.1
17 stars 6 forks source link

FontBakery Report -- Check has_ttfautohint_params: Failing #8

Closed eliheuer closed 6 years ago

eliheuer commented 6 years ago

Fontbakery report

[1] Staatliches-Regular.ttf
:fire: FAIL: Font has ttfautohint params? * [com.google.fonts/check/has_ttfautohint_params](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/has_ttfautohint_params) * :fire: **FAIL** Font is lacking ttfautohint params on its version strings on the name table.

Summary

:broken_heart: ERROR :fire: FAIL :warning: WARN :zzz: SKIP :information_source: INFO :bread: PASS
0 1 0 0 0 0
0% 100% 0% 0% 0% 0%
eliheuer commented 6 years ago

Can be fixed with ttx and this:

    <namerecord nameID="5" platformID="1" platEncID="0" langID="0x0" unicode="True">
      Version 1.000; ttfautohint (v1.8.2) -l 8 -r 28 -G 28 -x 14 -D latn -f cyrl -w G -c -X ""
    </namerecord>

Note: should also run ttfautohint on the font output.

davelab6 commented 6 years ago

That shouldn't be fixed by ttx hacking, haha

It should be fixed by running ttfautohint with the correct args :))

eliheuer commented 6 years ago

Yes, of course, the missing ttfautohint arg was -I

eliheuer commented 6 years ago

PR https://github.com/googlefonts/staatliches/pull/22 fixes this