search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
152 stars 43 forks source link

Check for FontParts font object #471

Closed benkiel closed 3 years ago

benkiel commented 3 years ago

FontParts has naked method that returns the lower level Defcon object in FontShell. This change would allow the passing of FontParts FontShell font objects to ufo2ft without issues like #443.

anthrotype commented 3 years ago

Thanks for the PR. If we decide to support fontParts in addition to naked defcon or ufoLib2 objects, then it'd make sense to also tests with that. And not just this particular feature writer code, but the whole ufo2ft library. Would you be willing to work on that?

anthrotype commented 3 years ago

you can always unwrap your fontParts font.naked() before you use the featureWriter (or ufo2ft in general), no?

benkiel commented 3 years ago

I can see how complex that would be to add, tests would be fairly simple (wrap test UFOs in FontParts, run tests). Yes, one can unwrap, but that's not a common thing for folks, so it would be nice if the library played well with FontParts fonts. It opens up easier command line manipulation.

You can close this, I'll make an Issue, and then see what it might take to do.