Consider scripts with no directionality to be LTR

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).

MIT License

152 stars 43 forks source link

Consider scripts with no directionality to be LTR #576

Closed simoncozens closed 2 years ago

simoncozens commented 2 years ago

Test for #575
Force scripts with no inherent directionality to LTR for kerning purposes; fixes #575

khaledhosny commented 2 years ago

What does HarfBuzz do for these scripts? Math can be set RTL, not sure about the others.

anthrotype commented 2 years ago

I don't know if related, but it looks like the fontTools.unicodedata' list of RTL scripts could be not up to date with latest Unicode 14, see the link in the comment at https://github.com/fonttools/fonttools/blob/e778f2c3f485101ad11cb595c427f579955c0714/Lib/fontTools/unicodedata/__init__.py#L137-L203 I believe I copied those from harfbuzz source code, but i forgot exactly where. Might be a good idea to update them just in case.

anthrotype commented 2 years ago

(ok, it's not related to this issue, but it's good that I checked: we were actually missing Old Uyghur from the RTL script list, it was added with Unicode 14.0 => https://github.com/fonttools/fonttools/pull/2499)