googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
151 stars 43 forks source link

Support Truetype instruction compilation #577

Closed jenskutilek closed 2 years ago

jenskutilek commented 2 years ago

Continuing from #335.

Main changes:

I also removed the separate additional UFOs from the test and implemented small tests for all methods of the InstructionCompiler as @anthrotype requested.

anthrotype commented 2 years ago

Thank you Jens. I hope to find the time too review this in the coming weeks, right now I am a bit busy with other things. Maybe you can ask @moyogo to take a look as well, if he's available.

jenskutilek commented 2 years ago

Thanks for letting me know. @moyogo, would you have time to take a look at my TrueType compiler code?

moyogo commented 2 years ago

LGTM! Sorry for the long delay.

anthrotype commented 2 years ago

Thanks Denis for reviewing this, however this is such a big change (1000 lines, 200 and more commits) and touches the core modules (the outlineCompiler) that I would like to also review this before it goes live.. I know it's been sitting here for months, but is there any particular reason you decided to merge now? I ask just to assess how urgent this is

moyogo commented 2 years ago

Ah, sorry I understood I was blocking this. What should we do?

anthrotype commented 2 years ago

What should we do?

revert, for the second time...

jenskutilek commented 2 years ago

I’ve made a new pull request with @moyogo’s and my changes , #654